//Hi All, //There are two vectors of string. Within vector also, there is a chance of duplicate values //Requirement is to have two vector merged so that result have only unique entries. //One sample case is shown as input vector names1 and names2 //Order of elements in result is not important. //I need your help to undertand code quality. Can this code be more precise and of improved quality? // thanks for solution from community (Boby Fischer) and answer is unordered_set instead of vector #include #include #include #include #include #include using namespace std; using namespace chrono; class TimeRecorder { time_point startTime; public: TimeRecorder() { startTime = high_resolution_clock::now(); } ~TimeRecorder() { time_point endTime = high_resolution_clock::now(); auto timetaken = duration_cast (endTime-startTime); cout << "Time taken to perform task is : " << timetaken.count() << " micro seconds" << endl; } }; vector getUniqueNames(vector& names1,vector& names2) { vector names; copy(names1.begin(),names1.end(),back_inserter(names)); copy(names2.begin(),names2.end(),back_inserter(names)); sort(names.begin(),names.end()); auto it = unique(names.begin(),names.end()); names.erase(it,names.end()); return names; } unordered_set getUniqueNamesBySet(vector& names1,vector& names2) { unordered_set names; for(auto name : names1) names.insert(name); for(auto name : names2) names.insert(name); return names; } int main() { vector names1 {"Ball","Apple","Cat","Ball"}; vector names2 {"Dog","Elephant","Cat"}; vector names ; { TimeRecorder objTimer; names = getUniqueNames(names1,names2); } cout << "***************************************************************" << endl; for(auto name : names) { cout << name << endl; } cout << "By set method : " << endl; unordered_set names_s; { TimeRecorder objTimer; names_s = getUniqueNamesBySet(names1,names2); } cout << "***************************************************************" << endl; for(auto name : names_s) { cout << name << endl; } return 0; }

UniqueInVectors