#include #include #include class Users { private: std::string m_username; std::string m_password; public: void setUsername(std::string username) { m_username = username; } void setPassword(std::string password) { m_password = password; } bool checkUsername(std::string username) { if (username == m_username) { return true; } else { return false; } } bool checkPassword(std::string password) { if (password == m_password) { return true; } else { return false; } } }; void setUsernameAndPassword(Users &user, std::string username, std::string password) { user.setUsername(username); user.setPassword(password); } void menu(std::vector &userVector) { std::cout << "1.New user\n2.Open user" << std::endl; int input; std::cin >> input; if (input == 1) { std::string username; std::string password; Users newUser; std::cout << "Enter username: "; std::getline(std::cin, username); std::cin.ignore(std::numeric_limits::max(), '\n'); std::cout << "Enter password: "; std::getline(std::cin, password); //std::cin.ignore(std::numeric_limits::max(), '\n'); setUsernameAndPassword(newUser, username, password); userVector.push_back(newUser); } if (input == 2) { //Print user id's std::cout << "Available users: " << std::endl; for (int n = 0; n < userVector.size(); n++) std::cout << n << std::endl; //enter choice: int choice; std::cout << "Open user ID: "; std::cin >> choice; //Request input: std::string username; std::string password; std::cout << "Enter username: "; std::getline(std::cin, username); std::cin.ignore(std::numeric_limits::max(), '\n'); std::cout << "Enter password: "; std::getline(std::cin, password); // std::cin.ignore(std::numeric_limits::max(), '\n'); if (userVector.at(choice).checkUsername(username)&&userVector.at(choice).checkPassword(password)) { std::cout << "Login successfull" << std::endl; } if(!userVector.at(choice).checkUsername(username)|| !userVector.at(choice).checkPassword(password)) { std::cout << "Wrong username or password" << std::endl; } } } int main() { std::vector userVector = {}; char reStart; do { menu(userVector); std::cout << "Goto menu(y/n)"; std::cin >> reStart; } while (reStart == 'y'); return 0; }

Why do this accept any username as long as password is correct? PS dont compile here.