my if and else condition in short